Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Metal Interconnections #321

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

codinja1188
Copy link
Contributor

Description:

What this PR does / why we need it:

Added support for metal interconnections

What issues has this PR fixed?

#307

internal/interconnections/interconnections.go Outdated Show resolved Hide resolved
internal/interconnections/retrieve.go Outdated Show resolved Hide resolved
internal/interconnections/retrieve.go Outdated Show resolved Hide resolved
docs/metal_interconnections_get.md Outdated Show resolved Hide resolved
internal/interconnections/create.go Outdated Show resolved Hide resolved
@cprivitere
Copy link
Contributor

cprivitere commented Aug 16, 2023

If I run this at all I get 404s:

> metal conn list
Error: Could not list Organization Interconnections: 404 Not Found
> metal conn create -n mynewInterconnection -m da -r primary -t shared
Error: could not create interconnections: 404 Not Found


createInterconnectionsCmd.Flags().StringVarP(&name, "name", "n", "", "Name of the interconnection")
createInterconnectionsCmd.Flags().StringVarP(&metro, "metro", "m", "", "metro in the interconnection")
createInterconnectionsCmd.Flags().StringVarP(&redundancy, "redundancy", "r", "", "Website URL of the organization.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options for -r should be like single or redundant, not a website URL.

@cprivitere
Copy link
Contributor

cprivitere commented Aug 16, 2023

I believe we're missing some stuff here, if you make a shared connection (VlanFabricVcCreateInput or VrfFabricVcCreateInput) you need to supply a "service_token_type" which I don't see referenced anywhere in this PR.

Here's the spec page I'm looking at:
https://deploy.equinix.com/developers/api/metal#tag/Interconnections/operation/createOrganizationInterconnection

@codinja1188
Copy link
Contributor Author

I believe we're missing some stuff here, if you make a shared connection (VlanFabricVcCreateInput or VrfFabricVcCreateInput) you need to supply a "service_token_type" which I don't see referenced anywhere in this PR.

Here's the spec page I'm looking at: https://deploy.equinix.com/developers/api/metal#tag/Interconnections/operation/createOrganizationInterconnection

we are supporting dedicated port input as of now

type: "dedicated"

inc := []string{}
exc := []string{}
if projectID != "" {
interConnections, proErr = pager.GetAllProjectInterconnections(c.Service, projectID, inc, exc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a new flag in this file that lets people pass in another projectID if they don't want to only check their default project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metal conn create -n "test-conn" -m da -r "primary"|"redundant" -t "dedicated"|"shared" -O <ORG_ID> -p <project_ID>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like it'd be right.

@codinja1188 codinja1188 temporarily deployed to external August 17, 2023 16:38 — with GitHub Actions Inactive
@cprivitere
Copy link
Contributor

I believe we're missing some stuff here, if you make a shared connection (VlanFabricVcCreateInput or VrfFabricVcCreateInput) you need to supply a "service_token_type" which I don't see referenced anywhere in this PR.
Here's the spec page I'm looking at: https://deploy.equinix.com/developers/api/metal#tag/Interconnections/operation/createOrganizationInterconnection

we are supporting dedicated port input as of now

type: "dedicated"

Gotcha, so just -t "dedicated" for now.

@@ -0,0 +1,91 @@
// Copyright © 2023 Jasmin Gacic <jasmin@stackpointcloud.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this license text at the top of every file

return fmt.Errorf("could not list Project Interconnections: %w", proerr)
}
} else if organizationID != "" {
interConnectionsList, _, err := c.Service.OrganizationListInterconnections(context.Background(), organizationID).Include(inc).Exclude(exc).Execute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination is being handled for project interconnections now, but it looks like there is also pagination data available for OrganizationListInterconnections

@codinja1188 codinja1188 changed the title Added support for Metal Interconnections fix: Added support for Metal Interconnections Oct 8, 2023
@codinja1188 codinja1188 temporarily deployed to external October 9, 2023 11:07 — with GitHub Actions Inactive
@codinja1188
Copy link
Contributor Author

Delete

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn delete
Error: required flag(s) "id" not set
Usage:
  metal interconnections delete -i <connection_id>  [flags]

Examples:
  # Deletes the specified interconnection:
  metal interconnections delete -i 7ec86e23-8dcf-48ed-bd9b-c25c20958277

Flags:
  -h, --help        help for delete
  -i, --id string   The UUID of the interconnection.

Global Flags:
      --config string         Path to JSON or YAML configuration file
      --exclude strings       Comma separated Href references to collapse in results, may be dotted three levels deep
      --filter stringArray    Filter 'get' actions with name value pairs. Filter is not supported by all resources and is implemented as request query parameters.
      --http-header strings   Headers to add to requests (in format key=value)
      --include strings       Comma separated Href references to expand in results, may be dotted three levels deep
  -o, --output string         Output format (*table, json, yaml). env output formats are (*sh, terraform, capp).
      --search string         Search keyword for use in 'get' actions. Search is not supported by all resources.
      --sort-by string        Sort fields for use in 'get' actions. Sort is not supported by all resources.
      --sort-dir string       Sort field direction for use in 'get' actions. Sort is not supported by all resources.
      --token string          Metal API Token (METAL_AUTH_TOKEN)

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn delete -i b090309f-0286-4586-84bd-3c349337a2c3
connection deletion initiated. Please check 'metal interconnections get -i b090309f-0286-4586-84bd-3c349337a2c3 ' for status

@cprivitere cprivitere temporarily deployed to external October 9, 2023 17:46 — with GitHub Actions Inactive
@codinja1188 codinja1188 temporarily deployed to external October 10, 2023 13:54 — with GitHub Actions Inactive
@codinja1188
Copy link
Contributor Author

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "test-conn" -m da -r "primary" -t "dedicated" -p <Project_ID>
+--------------------------------------+-----------+-----------+-------------------------------+
|                  ID                  |   NAME    |   TYPE    |            CREATED            |
+--------------------------------------+-----------+-----------+-------------------------------+
| 3f508528-d8e3-429d-bbd8-b1c0ebb6a5f6 | test-conn | dedicated | 2023-10-12 14:00:33 +0000 UTC |
+--------------------------------------+-----------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "test-conn" -m da -r "redundant" -t "dedicated" -p <Project_ID>
+--------------------------------------+-----------+-----------+-------------------------------+
|                  ID                  |   NAME    |   TYPE    |            CREATED            |
+--------------------------------------+-----------+-----------+-------------------------------+
| 7f75dc3c-d186-48bf-a983-32e01d74b607 | test-conn | dedicated | 2023-10-12 14:01:26 +0000 UTC |
+--------------------------------------+-----------+-----------+-------------------------------+

@codinja1188 codinja1188 temporarily deployed to external October 12, 2023 16:04 — with GitHub Actions Inactive
@codinja1188
Copy link
Contributor Author

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -O 4d12f460-8c5e-43ea-986d-529d328815ee
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| 3f508528-d8e3-429d-bbd8-b1c0ebb6a5f6 | test-conn                                                  | dedicated | 2023-10-12 14:00:33 +0000 UTC |
| 7f75dc3c-d186-48bf-a983-32e01d74b607 | test-conn                                                  | dedicated | 2023-10-12 14:01:26 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| 3f508528-d8e3-429d-bbd8-b1c0ebb6a5f6 | test-conn                                                  | dedicated | 2023-10-12 14:00:33 +0000 UTC |
| 7f75dc3c-d186-48bf-a983-32e01d74b607 | test-conn                                                  | dedicated | 2023-10-12 14:01:26 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -i 785fb586-9046-4d05-bee7-e8f752fa3033
+--------------------------------------+------------------------------------------------------------+--------+-------------------------------+
|                  ID                  |                            NAME                            |  TYPE  |            CREATED            |
+--------------------------------------+------------------------------------------------------------+--------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared | 2023-10-05 22:31:38 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+--------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "test-conn" -m da -r "primary" -t "dedicated" -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+-----------+-----------+-------------------------------+
|                  ID                  |   NAME    |   TYPE    |            CREATED            |
+--------------------------------------+-----------+-----------+-------------------------------+
| d17ce1ca-fedb-451f-af23-1e5611a3dbf3 | test-conn | dedicated | 2023-10-13 14:17:17 +0000 UTC |
+--------------------------------------+-----------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "test-conn-1" -m da -r "primary" -t "shared" -p 5211fb64-1e5b-402f-a904-f86427a5dc55
Error: could not create interconnections: 422 Unprocessable Entity
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "test-conn-1" -m da -r "redundant" -t "dedicated" -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+-------------+-----------+-------------------------------+
|                  ID                  |    NAME     |   TYPE    |            CREATED            |
+--------------------------------------+-------------+-----------+-------------------------------+
| 5423d90e-704d-45a4-a1dd-8c8c51ffd356 | test-conn-1 | dedicated | 2023-10-13 14:18:45 +0000 UTC |
+--------------------------------------+-------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| 3f508528-d8e3-429d-bbd8-b1c0ebb6a5f6 | test-conn                                                  | dedicated | 2023-10-12 14:00:33 +0000 UTC |
| 7f75dc3c-d186-48bf-a983-32e01d74b607 | test-conn                                                  | dedicated | 2023-10-12 14:01:26 +0000 UTC |
| d17ce1ca-fedb-451f-af23-1e5611a3dbf3 | test-conn                                                  | dedicated | 2023-10-13 14:17:17 +0000 UTC |
| 5423d90e-704d-45a4-a1dd-8c8c51ffd356 | test-conn-1                                                | dedicated | 2023-10-13 14:18:45 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn delete -i d17ce1ca-fedb-451f-af23-1e5611a3dbf3
connection deletion initiated. Please check 'metal interconnections get -i d17ce1ca-fedb-451f-af23-1e5611a3dbf3 ' for status

@codinja1188
Copy link
Contributor Author

codinja1188 commented Oct 27, 2023

Test results:

Vasubabus-MacBook-Pro:metal-cli vasubabu$ make build
go build -ldflags "-X github.com/equinix/metal-cli/cmd.Version=c4dc1dc -X github.com/equinix/metal-cli/cmd.Build=c4dc1dc" -o bin/metal ./cmd/metal
Vasubabus-MacBook-Pro:metal-cli vasubabu$ cd bin/
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| e9763728-d4d7-47de-b1ee-dc6504243327 | test-conn                                                  | dedicated | 2023-10-27 13:00:02 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn update -i e9763728-d4d7-47de-b1ee-dc6504243327 -d "vasu testing interconnections"
+--------------------------------------+-----------+-----------+-------------------------------+
|                  ID                  |   NAME    |   TYPE    |            CREATED            |
+--------------------------------------+-----------+-----------+-------------------------------+
| e9763728-d4d7-47de-b1ee-dc6504243327 | test-conn | dedicated | 2023-10-27 13:00:02 +0000 UTC |
+--------------------------------------+-----------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| e9763728-d4d7-47de-b1ee-dc6504243327 | test-conn                                                  | dedicated | 2023-10-27 13:00:02 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn create -n "vasu-interconn" -m da -r "primary" -t "dedicated" -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+----------------+-----------+-------------------------------+
|                  ID                  |      NAME      |   TYPE    |            CREATED            |
+--------------------------------------+----------------+-----------+-------------------------------+
| 68282163-509b-4707-bb5d-4b0f5db5b594 | vasu-interconn | dedicated | 2023-10-27 13:32:48 +0000 UTC |
+--------------------------------------+----------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -p 5211fb64-1e5b-402f-a904-f86427a5dc55
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| e9763728-d4d7-47de-b1ee-dc6504243327 | test-conn                                                  | dedicated | 2023-10-27 13:00:02 +0000 UTC |
| 68282163-509b-4707-bb5d-4b0f5db5b594 | vasu-interconn                                             | dedicated | 2023-10-27 13:32:48 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -i 68282163-509b-4707-bb5d-4b0f5db5b594
+--------------------------------------+----------------+-----------+-------------------------------+
|                  ID                  |      NAME      |   TYPE    |            CREATED            |
+--------------------------------------+----------------+-----------+-------------------------------+
| 68282163-509b-4707-bb5d-4b0f5db5b594 | vasu-interconn | dedicated | 2023-10-27 13:32:48 +0000 UTC |
+--------------------------------------+----------------+-----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -o 4d12f460-8c5e-43ea-986d-529d328815ee
2023/10/27 19:03:24 unknown format: "4d12f460-8c5e-43ea-986d-529d328815ee". Using default.
+----+------+------+---------+
| ID | NAME | TYPE | CREATED |
+----+------+------+---------+
+----+------+------+---------+

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -O 4d12f460-8c5e-43ea-986d-529d328815ee
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| e9763728-d4d7-47de-b1ee-dc6504243327 | test-conn                                                  | dedicated | 2023-10-27 13:00:02 +0000 UTC |
| 68282163-509b-4707-bb5d-4b0f5db5b594 | vasu-interconn                                             | dedicated | 2023-10-27 13:32:48 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn delete -i e9763728-d4d7-47de-b1ee-dc6504243327
connection deletion initiated. Please check 'metal interconnections get -i e9763728-d4d7-47de-b1ee-dc6504243327 ' for status
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal conn get -O 4d12f460-8c5e-43ea-986d-529d328815ee
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
|                  ID                  |                            NAME                            |   TYPE    |            CREATED            |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------+
| 785fb586-9046-4d05-bee7-e8f752fa3033 | ansible-integration-test-connection-gnzlmmno-TestConn-vlan | shared    | 2023-10-05 22:31:38 +0000 UTC |
| f8c832de-ec40-4f74-b142-9a7c0e86caae | ansible-integration-test-connection-pzwqmfsd-TestConn-vlan | shared    | 2023-10-05 22:26:57 +0000 UTC |
| c84eaccc-b97f-4539-ac81-b58619ed3728 | ansible-integration-test-connection-gmzknjxd-TestConn-vlan | shared    | 2023-10-05 22:29:10 +0000 UTC |
| 68282163-509b-4707-bb5d-4b0f5db5b594 | vasu-interconn                                             | dedicated | 2023-10-27 13:32:48 +0000 UTC |
+--------------------------------------+------------------------------------------------------------+-----------+-------------------------------

@displague displague changed the title fix: Added support for Metal Interconnections feat: Added support for Metal Interconnections Nov 9, 2023
RunE: func(cmd *cobra.Command, args []string) error {
cmd.SilenceUsage = true

_, _, err := c.Service.DeleteInterconnection(context.Background(), connectionID).Execute()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete should require --force or an interactive prompt.

I'll open this as a new issue to keep this feature unblocked as-is.

@displague displague merged commit cd40bb0 into equinix:main Nov 9, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants